----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53380/#review154689 -----------------------------------------------------------
Fix it, then Ship it! Thanks for fixing this, LGTM modulo one issue I opened, and the issue raised by Joseph. src/CMakeLists.txt (lines 521 - 524) <https://reviews.apache.org/r/53380/#comment224362> Please move this patch before https://reviews.apache.org/r/53379/ (i.e., reverse the order of the chain). This will lead to these symbols being defined twice after this patch, but doesn't negatively affect the build. It would however allow us to bisect the cmake build across this chain w/o new failures. - Benjamin Bannier On Nov. 2, 2016, 4:39 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53380/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 4:39 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Alex > Clemmer, and Joseph Wu. > > > Bugs: MESOS-6309 > https://issues.apache.org/jira/browse/MESOS-6309 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 > > Diff: https://reviews.apache.org/r/53380/diff/ > > > Testing > ------- > > cmake ..;make (+functional check) > > > Thanks, > > Till Toenshoff > >
