> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1055 > > <https://reviews.apache.org/r/50523/diff/2/?file=1458001#file1458001line1055> > > > > We should use a `continuation` here, you can refer to > > https://reviews.apache.org/r/50841/diff/5#index_header to get some hints. > > Kevin Klues wrote: > At first glance, it looks like this line is blocking because of the > `.get()`. However, the line is just confusing because both `allocator` and > `gpus` are of type `Option`. While there are still problems with the line > (i.e. it's return value is ignored!), it does not seem to block anywhere. See > my comments later on for how to address this.
Please provide your inputs on the new code out for review. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/#review146261 ----------------------------------------------------------- On Aug. 24, 2016, 12:56 a.m., Rajat Phull wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50523/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 12:56 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, Yubo Li, and Vikrama > Ditya. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Updated docker recovery to account for GPU resources. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > src/tests/containerizer/docker_containerizer_tests.cpp > 42d4364b6fcbc94c7852721511001c103cb5a90d > > Diff: https://reviews.apache.org/r/50523/diff/ > > > Testing > ------- > > GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_LaunchWithGpuRecovery" > make -j check > > > Thanks, > > Rajat Phull > >
