----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53465/#review154941 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 747) <https://reviews.apache.org/r/53465/#comment224732> Is this correct? Why is it sufficient to recursively call this on the status of the parent? Is it because (for now) we always share the same cgroups as our parent? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1276) <https://reviews.apache.org/r/53465/#comment224734> Ditto on this one. - Kevin Klues On Nov. 4, 2016, 7:07 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53465/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 7:07 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: MESOS-6465 and MESOS-6528 > https://issues.apache.org/jira/browse/MESOS-6465 > https://issues.apache.org/jira/browse/MESOS-6528 > > > Repository: mesos > > > Description > ------- > > Prior to this patch, the ContainerStatus inside the TaskStatus for a > task in the default executor is not correct. The agent always gets the > container status of the top level container, even if the task might > correspond to a nested container. > > This patch fixed this issue by letting the executor set the container > ID for the task (because only it has the knowledge about this > mapping), and the agent will use that container ID to get the proper > container status. > > > Diffs > ----- > > src/launcher/default_executor.cpp b8a88ad6e361720dc7d02c9423db3e67226f779f > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2f6723c64261fb3295626d6479fe844fb23b0650 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 939142e36b926d9e4201d35dedd25e32e9f8c63c > src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 > > Diff: https://reviews.apache.org/r/53465/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
