> On Nov. 4, 2016, 1:11 p.m., Joseph Wu wrote: > > src/tests/containerizer.cpp, lines 402-403 > > <https://reviews.apache.org/r/53456/diff/1/?file=1554056#file1554056line402> > > > > I personally prefer to not import any of the `process` namespace. Many > > of the functions there have very generic sounding names, which makes code > > like this slightly harder to read. > > Benjamin Mahler wrote: > Do you mean functions or types? Not importing the functions sounds ok to > me.
The functions in this case. I also prefer, say, `process::Future` over `Future`. But both are valid stylistically (I think). - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53456/#review154977 ----------------------------------------------------------- On Nov. 3, 2016, 11:15 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53456/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 11:15 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Avoid 'using namespace' clause in the test containerizer. > > > Diffs > ----- > > src/tests/containerizer.cpp c2208660352e5cf62cec5c7b92ec67fea62aea49 > > Diff: https://reviews.apache.org/r/53456/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
