> On Nov. 4, 2016, 8:16 p.m., Kevin Klues wrote: > > include/mesos/mesos.proto, line 2115 > > <https://reviews.apache.org/r/53450/diff/2/?file=1553918#file1553918line2115> > > > > I see you changed s/TtyInfo/TTYInfo/ > > > > Is this intentional? I know @bmahler has lamented in the past about > > decisions like this. (e.g. `HTTPScheduler` he would prefer to be > > `HttpScheduler`). > > Vinod Kone wrote: > I might be missing context but why do we prefer HttpScheduler to > HTTPScheduler? HTTP is an abbrevation, so all caps seems better to me. Note > that we have TCPCheckInfo, HTTPCheckInfo, URI, URL, etc protos already.
You'd have to ask @bmahler his thoughts on this. I just know it came up a few times during my GPU reviews. For consistency though (since so many other protobufs are already written like this), I think it's probably better to leave it as ALL CAPS. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53450/#review154980 ----------------------------------------------------------- On Nov. 4, 2016, 12:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53450/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 12:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-6525 > https://issues.apache.org/jira/browse/MESOS-6525 > > > Repository: mesos > > > Description > ------- > > Added to ContainerInfo because we want to be able to attach to > containers that are launched without a CommandInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 905a34bb13c2fcd1b22ef4e9605405ef84711c25 > include/mesos/v1/mesos.proto b72069a6caff0b163d9d9cae45c3caa0b25de38f > > Diff: https://reviews.apache.org/r/53450/diff/ > > > Testing > ------- > > make > > > Thanks, > > Vinod Kone > >
