----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/#review154456 -----------------------------------------------------------
src/examples/CMakeLists.txt (line 21) <https://reviews.apache.org/r/49863/#comment224020> We don't really need to list the library name here. Ditto on the other definitions. src/examples/CMakeLists.txt (lines 114 - 122) <https://reviews.apache.org/r/49863/#comment224286> The `target_link_libraries` command below is smart enough to include dependencies from dependencies. So if you link to `MESOS_TARGET`, you automagically get all the 3rdparty libraries too. This means you don't need these lines. See: https://cmake.org/cmake/help/v3.0/command/target_link_libraries.html > Library dependencies are transitive by default with this signature. When this target is linked into another target then the libraries linked to this target will appear on the link line for the other target too. src/examples/CMakeLists.txt (lines 126 - 138) <https://reviews.apache.org/r/49863/#comment224021> Even though we have the default linkage variable, it doesn't make sense to statically link modules. These should be `SHARED`. But on Windows, we should exclude the test modules. --- Also, for readability, it would be nice to line up the variables vertically. (Same below) src/examples/cmake/ExamplesConfigure.cmake (line 47) <https://reviews.apache.org/r/49863/#comment224019> Everything in this file from here and below is un-used. - Joseph Wu On Oct. 4, 2016, 4:45 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49863/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 4:45 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Builds shared libraries for dynamically loading them by various tests: > libexamplemodule, libtestauthorizer, libtestisolator, > libtestresource_estimator, libtestallocator, libtestcontainer_logger, > libtestmastercontender, libtestanonymous, libtesthook, > libtestmasterdetector, libtestauthentication, libtesthttpauthenticator, > libtestqos_controller. > > > Diffs > ----- > > CMakeLists.txt ee8f565586b958929bc4e95b09827244d6d4155f > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/49863/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
