----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review155492 -----------------------------------------------------------
Ship it! Lots great, thanks a lot. - Benjamin Bannier On Nov. 9, 2016, 8:37 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 8:37 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Add hardened flags for Mesos. > Take compile flag macro at 1a869696e4129279f7b99c3f9052717354b79a86. > > > Diffs > ----- > > configure.ac 5380cbc > m4/ax_check_compile_flag.m4 PRE-CREATION > src/Makefile.am 5a47c93 > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
