-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53354/
-----------------------------------------------------------
(Updated Nov. 11, 2016, 11:26 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updated all of Jie's comments except the one about the test.
Bugs: MESOS-6464
https://issues.apache.org/jira/browse/MESOS-6464
Repository: mesos
Description
-------
The namespace-related isolators now do different things depending on
whether they are launching a "normal" nested container or a "debug"
nested container. Normal nested containers clone a new mount namespace
as well as a new pid namespace. Debug nested cotnainers do not -- they
simply inherit these namespaces from their parent.
Diffs (updated)
-----
src/slave/containerizer/mesos/containerizer.cpp
44225ebf63d8dd93be9b60fff496c74dc6c3a5ad
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
df16b8fee6799a69c7d96f33a5049bd9787c48f5
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
e3756c920081f2944bf4b640edf0a83f42784586
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp
0d9ec57d9aa83bcc6cc2e5a8d75f2e2251179b1b
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
50b43777b1e470898de139e2dae398ebb2c0d6bb
src/slave/containerizer/mesos/isolators/volume/image.cpp
210e67ad0d84f52135e77184f21e574c9e31628d
src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
7b976d29226c3e0a4d52922e9d2f7e685de72297
src/slave/containerizer/mesos/linux_launcher.cpp
0305d14c1f791c93edcd3b32786b483b15f40a2d
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
e6c690c411f57138207044f31b4816bd4090c1b7
Diff: https://reviews.apache.org/r/53354/diff/
Testing
-------
make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues