> On Nov. 12, 2016, 12:45 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1233-1237 > > <https://reviews.apache.org/r/53352/diff/2/?file=1556845#file1556845line1233> > > > > This patch itself is not atomic because on non-linux systems, we'll > > specify 'enterNamespaces', even if posix launcher is used! > > > > Please make sure next time we make each patch atomic.
Yep. My bad. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53352/#review155759 ----------------------------------------------------------- On Nov. 8, 2016, 9:54 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53352/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 9:54 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6464 > https://issues.apache.org/jira/browse/MESOS-6464 > > > Repository: mesos > > > Description > ------- > > Instead of only taking the namespaces to *clone* inside a newly forked > container, 'LinuxLauncher->fork()' now takes a list of namespaces to > enter inside a parent container before forking. When both an *enter* > and a *clone* for the same namespace are passed, we will first enter > the namespace of the parent, and then clone a new one. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 > src/slave/containerizer/mesos/containerizer.cpp > e57064c768937969ba4a071ae80165ccab2f1dff > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > af9f3736b487b595e8768e56ce60dc4823db28a1 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > df16b8fee6799a69c7d96f33a5049bd9787c48f5 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > a1283e5ee92c916baaf9fca8ce314d597e8421b3 > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > e3756c920081f2944bf4b640edf0a83f42784586 > src/slave/containerizer/mesos/isolators/namespaces/pid.cpp > 0d9ec57d9aa83bcc6cc2e5a8d75f2e2251179b1b > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 50b43777b1e470898de139e2dae398ebb2c0d6bb > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > 48202fb5bf1ede71b80760844c6d8a36ca7c700c > src/slave/containerizer/mesos/isolators/volume/image.cpp > 210e67ad0d84f52135e77184f21e574c9e31628d > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > 7b976d29226c3e0a4d52922e9d2f7e685de72297 > src/slave/containerizer/mesos/launcher.hpp > 6ceb02de5dc143e545e2fec43e2608916e46b898 > src/slave/containerizer/mesos/launcher.cpp > b45313fd717f9553ccb0cbe9e8ac095e2536944a > src/slave/containerizer/mesos/linux_launcher.hpp > d2353055a838c872d5852982cfede8e38c6e8701 > src/slave/containerizer/mesos/linux_launcher.cpp > 0305d14c1f791c93edcd3b32786b483b15f40a2d > src/tests/containerizer/isolator_tests.cpp > 8fefeef8c83ed2ab01f56a1ec572d3acb307143c > src/tests/containerizer/launcher.hpp > 773b458f19e11b219c3f13a43f2b751a4bbe7b85 > src/tests/containerizer/launcher.cpp > a92d9890f0931425d69ef8ce0896d081b8722079 > src/tests/containerizer/mesos_containerizer_tests.cpp > 8cb7d4e5585eda36b875812b7cd914f98cf70487 > src/tests/containerizer/port_mapping_tests.cpp > fbdc0db9238c85d2f6eaba7d13ee5ce23342b527 > > Diff: https://reviews.apache.org/r/53352/diff/ > > > Testing > ------- > > make -j check > > > Thanks, > > Kevin Klues > >
