> On Nov. 15, 2016, 6:44 a.m., Sivaram Kannan wrote: > > src/slave/containerizer/docker.cpp, line 1286 > > <https://reviews.apache.org/r/53473/diff/6/?file=1563496#file1563496line1286> > > > > Does not make much sense to run docker containrizer with anyother user > > other than root right??
We're modulating the user inside the container, rather than the user creating the container. The agent still needs to be root, but the container does not need to be. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/#review155917 ----------------------------------------------------------- On Nov. 14, 2016, 1:52 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53473/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 1:52 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Add new param user to logrotate's prepare function. > > > Diffs > ----- > > include/mesos/slave/container_logger.hpp > 939974736f9eb744c83036e074718d2a1eba8b0a > src/slave/container_loggers/lib_logrotate.hpp > 28fdf3bdcc66d473521b377f66ab0b48f6900f58 > src/slave/container_loggers/lib_logrotate.cpp > 53698d339f0f4d2dc916b53239ca0c36bbebcd42 > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > src/slave/container_loggers/sandbox.hpp > e0aeb32a9ec83af049af8a10010b819c1d8b25d8 > src/slave/container_loggers/sandbox.cpp > cc263ebef7e0c3e778fabafa49faa6dd315adc45 > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > src/slave/containerizer/mesos/containerizer.cpp > ec4ae32485a7ab6c9f73c512004d1220482a188e > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53473/diff/ > > > Testing > ------- > > Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > Run the mesos-logrotate-logger as root user and verify whether the logs are > getting rotated. > > > Thanks, > > Sivaram Kannan > >
