> On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 416-440 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line416> > > > > What is this used for?
This is called from the function below. It is used when we create two pipes int_fd(s) holding anonimous pipes as the Posix pipe API. I think it can be avoided and default to a socket<->pipe model. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 356-379 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line356> > > > > Do we actually need this for something..? There are several places where the int_fd is used in the logs. Hence '<<'. Furthermore the handles are serialized for the containerizer command line and are deserialized in the containerizer. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, line 148 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line148> > > > > What is `NONE` for? it doesn't seem like we use it? None is used when pipe are used on both legs of the adapter. > On Nov. 17, 2016, 12:57 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 36-38 > > <https://reviews.apache.org/r/52544/diff/6/?file=1565250#file1565250line36> > > > > What are these for? closed is used to detect on Mesos code a leaked. Also the IO from os:: namespace may use this flag to reject the operation on a closed handle. Otherwise we see strange error deep in CRT. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52544/#review156151 ----------------------------------------------------------- On Nov. 16, 2016, 6:37 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52544/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 6:37 p.m.) > > > Review request for mesos, Alex Naparu, Alex Clemmer, Joseph Wu, and Michael > Park. > > > Repository: mesos > > > Description > ------- > > In POSIX the `socket`,`pipe` and the `filedescriptor` are > represented by an int type. In Windows a socket is kept in a > `SOCKET` type (64 bit wide), a pipe in a `HANDLE` (64 bit wide) and > a file descriptor in an int. This class unifies all Windows types. > In POSIX this class is an int. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os.hpp > bd085e4e29bbdb2d2baaaeff1d10c0bd95ca65ba > 3rdparty/stout/include/stout/os/filedescriptor.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/52544/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
