----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53654/#review156422 -----------------------------------------------------------
Ship it! LGTM, thanks for the cleanup. - Anand Mazumdar On Nov. 10, 2016, 6:46 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53654/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 6:46 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > This fixes two places where we were needlessly copying an > `HttpConnection`. Aside from the performance consequences, making a copy > suggests to the reader that a copy is semantically necessary, which is > not the case here. > > > Diffs > ----- > > src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881 > src/master/master.cpp f0b629737ace71f14f5c21eb918c3ef1da3c0837 > > Diff: https://reviews.apache.org/r/53654/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
