----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53805/#review156477 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (line 16) <https://reviews.apache.org/r/53805/#comment226659> It seems ok to me to assume that if you include <process/socket.hpp> you have the necessary includes to pass either windows or posix values for the 'how' argument, since our current strategy for windows is to let callers use the posix macro names. 3rdparty/libprocess/src/tests/http_tests.cpp (line 242) <https://reviews.apache.org/r/53805/#comment226660> Per the comment in the previous review, seems we need to add `SHUT_RDWR` and `SHUT_WR` so that call-sites like these compile on windows? - Benjamin Mahler On Nov. 16, 2016, 7:22 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53805/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 7:22 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > Updated libprocess test to use new 'Socket::shutdown' parameter. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 533104c93dd1eaf67bf3752163d2e0cad090078d > > Diff: https://reviews.apache.org/r/53805/diff/ > > > Testing > ------- > > NOTE that there is currently an issue when running the entire test suite: > `Scheme/HTTPTest.SocketEOF/0` fails with a file permission issue. Will update > this chain with the fix soon. > > > Thanks, > > Greg Mann > >
