> On Nov. 22, 2016, 2:47 p.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, line 105 > > <https://reviews.apache.org/r/53950/diff/1/?file=1567990#file1567990line105> > > > > I am thinking if we could > > > > ``` > > const uint16_t testPort = getFreePort().get(); > > ``` > > > > Since no all the health check test cases require a free port.
Makes sense, code adjusted. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53950/#review156571 ----------------------------------------------------------- On Nov. 22, 2016, 4:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53950/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 4:49 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-6618 > https://issues.apache.org/jira/browse/MESOS-6618 > > > Repository: mesos > > > Description > ------- > > Avoided hardcoding ports in some tests. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > c478d56ffd734b26fd2dbd7bb1ca02ce929f3f16 > src/tests/health_check_tests.cpp 2c7022a1210ade6d7eb594c4f8934f2bdb2aee35 > > Diff: https://reviews.apache.org/r/53950/diff/ > > > Testing > ------- > > make check (SSL build OS X clang trunk w/ optimizations; default build > ubuntu-14.04 gcc-4.8.4 w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
