----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53877/#review156618 -----------------------------------------------------------
Ship it! src/docker/docker.cpp (line 535) <https://reviews.apache.org/r/53877/#comment226793> Minor nit: Should we change `file` to something like `environmentVariables` or `environment` because it's a string, not a file. - Kapil Arya On Nov. 22, 2016, 2:36 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53877/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 2:36 p.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, Jie Yu, Kapil Arya, and > Joseph Wu. > > > Bugs: MESOS-6566 > https://issues.apache.org/jira/browse/MESOS-6566 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/docker/docker.cpp f03ea7fa55e976e44282503261ac50e1502592a2 > > Diff: https://reviews.apache.org/r/53877/diff/ > > > Testing > ------- > > ``` > $ make check > ``` > > ``` > $ ./src/mesos-execute --command="sleep 200" --containerizer=docker > --docker_image=alpine --env='{"foo": "bar"}' --master=149.202.202.185:5050 > ``` > > ``` > $ ps aux > root 27645 0.2 0.0 372852 30180 ? Sl 15:50 0:00 docker -H > unix:///var/run/docker.sock run --cpu-shares 1024 --memory 134217728 > --env-file /tmp/l53ILz/ktpuDS -v > /tmp/mesos/slaves/91b671fd-3c83-425e-96c2-26ecdc410028-S0/frameworks/91b671fd-3c83-425e-96c2-26ecdc410028-0001/executors/test/runs/a75fc411-3d18-44f1-a562-9f759c281da0:/mnt/mesos/sandbox > --net host --entrypoint /bin/sh --name > mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 > alpine -c sleep 200 > ``` > > ``` > $ more /tmp/l53ILz/ktpuDS > foo=bar > MESOS_SANDBOX=/mnt/mesos/sandbox > MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0 > ``` > > > Thanks, > > Till Toenshoff > >