----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53611/#review156638 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (line 414) <https://reviews.apache.org/r/53611/#comment226834> See below. include/mesos/v1/mesos.proto (line 414) <https://reviews.apache.org/r/53611/#comment226829> "// Amount of time after the task is launched during which health check failures are ignored. Note that once the health check passes for the first time, the grace period does not apply anymore." Would also be good to cover whether `grace_period_seconds` includes `delay_seconds` or not. - Neil Conway On Nov. 9, 2016, 5:05 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53611/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 5:05 p.m.) > > > Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and > Till Toenshoff. > > > Bugs: MESOS-5597 > https://issues.apache.org/jira/browse/MESOS-5597 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca > include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 > > Diff: https://reviews.apache.org/r/53611/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
