> On Nov. 10, 2016, 7:19 a.m., Kapil Arya wrote: > > Before doing full review, I am wondering if we can create a new protobuf > > called `DockerExecutorPrepareInfo` or something similar with the idea that > > we can pass on not only environment variables, but also volumes (and any > > other options in future). The volumes are interesting because a module > > might want to make available certain file paths within Docker executor. Is > > this something reasonable? > > Till Toenshoff wrote: > I like that idea a lot. Let me reiterate with that on this patch.
Are we dropping this patch in favor of https://reviews.apache.org/r/53998/ ? - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53308/#review155592 ----------------------------------------------------------- On Oct. 31, 2016, 8:49 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53308/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 8:49 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > ------- > > Allows for modifying the environment effective for the executor itself. > Additionally allows the hook to receive the location of the sandbox folder. > > > Diffs > ----- > > include/mesos/hook.hpp c8a58641e0768628a9028a70d8c244448f7fb412 > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/53308/diff/ > > > Testing > ------- > > make check and functional test in a hook-module > > > Thanks, > > Till Toenshoff > >
