----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/#review156767 -----------------------------------------------------------
Ship it! src/slave/container_loggers/logrotate.hpp (line 116) <https://reviews.apache.org/r/52308/#comment227042> We (relatively recently) updated the style of flags. When you pass in a field by reference, it should now include some disambiguation for the class. s/user/Flags::user/ ^ I can fix this before committing. - Joseph Wu On Nov. 17, 2016, 7:38 a.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52308/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 7:38 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Add variable user to handle switchUser passed from executor. > > > Diffs > ----- > > src/slave/container_loggers/logrotate.hpp > d1db69236f5a9b1dbb3113ad02218a512afdb46b > > Diff: https://reviews.apache.org/r/52308/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
