----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53936/#review156796 -----------------------------------------------------------
Fix it, then Ship it! src/slave/flags.cpp (line 261) <https://reviews.apache.org/r/53936/#comment227095> let's use false as the default so most users won't be surprised by that. - Jie Yu On Nov. 20, 2016, 10:37 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53936/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 10:37 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6467 > https://issues.apache.org/jira/browse/MESOS-6467 > > > Repository: mesos > > > Description > ------- > > Added agent flags to enable/disable launching an io switchboard server. > > > Diffs > ----- > > src/slave/flags.hpp 3c292bac9394347318865f49782907def6541742 > src/slave/flags.cpp 76609f94482a792f4c8db480e604d98d172abb04 > > Diff: https://reviews.apache.org/r/53936/diff/ > > > Testing > ------- > > make > > > Thanks, > > Kevin Klues > >
