----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/#review156800 -----------------------------------------------------------
Ship it! Looks good to me. Although, I am not sure about the Windows part. - Jie Yu On Nov. 15, 2016, 5:09 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53626/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 5:09 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6556 > https://issues.apache.org/jira/browse/MESOS-6556 > > > Repository: mesos > > > Description > ------- > > Add net::setDomainname() helper API. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/net.hpp > 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 > 3rdparty/stout/include/stout/windows/net.hpp > 1bed115cb848332bf9c31e455b2d001c173face9 > > Diff: https://reviews.apache.org/r/53626/diff/ > > > Testing > ------- > > make check > > > Thanks, > > James Peach > >
