----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53459/#review157066 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/socket.hpp (line 47) <https://reviews.apache.org/r/53459/#comment227478> fix the alignment? 3rdparty/libprocess/src/poll_socket.cpp (line 108) <https://reviews.apache.org/r/53459/#comment227498> have you rebased? You need to close 's' if 'create' fails. 3rdparty/libprocess/src/socket.cpp (lines 39 - 48) <https://reviews.apache.org/r/53459/#comment227504> Why you need a lambda here? - Jie Yu On Nov. 28, 2016, 5:40 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53459/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 5:40 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The templated `Socket` will enable us to provide type safe > functionality for different addresses, ultimately `inet::Address` and > `unix::Address` (and likely eventually `inet6::Address` as well). > > Also introduced the `inet` namespace and updated the code to > explicitly use `inet::Address` and `inet::Socket`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > 04e3155d65f476208fa852e83b79d173b66288fd > 3rdparty/libprocess/include/process/firewall.hpp > ad461caaa95c1098d5449307b0c07508e22c3c37 > 3rdparty/libprocess/include/process/http.hpp > a684e09c8353112a0656b7e899a469c1e022e93b > 3rdparty/libprocess/include/process/pid.hpp > 36453b600c91c2ddc057db15ec5938e6c819260b > 3rdparty/libprocess/include/process/process.hpp > de23f0cfef4bf95ce33c5b336e2901f416a8502e > 3rdparty/libprocess/include/process/socket.hpp > f798af7879546d71e8ef4a295c9cf489a70cb61f > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 21a0fc45b55a368a21b3e616c751ab43eebd4902 > 3rdparty/libprocess/src/encoder.hpp > 515821acb20d2a09d10781af17dcac472a7c117a > 3rdparty/libprocess/src/http.cpp 3f16f293a5c5cd0b31a85efe94cb6f8019543d45 > 3rdparty/libprocess/src/libevent_ssl_socket.hpp > acb00d41c637a318b2f16fff9e97998b9c79b809 > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 5c0929d3d9f5595bd2f343b98b899fd6b06a67b2 > 3rdparty/libprocess/src/pid.cpp f9313cde006dd067be265343eed60412ad6b0b95 > 3rdparty/libprocess/src/poll_socket.hpp > d04f3f2d1bcf70464ac659b29f96574bbd233414 > 3rdparty/libprocess/src/poll_socket.cpp > eb7b48713edd30b545d7be95b5d51b0f71bd422a > 3rdparty/libprocess/src/process.cpp > e9a4bbb0b2410e0260d120b97e73972c94eb0f26 > 3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 > 3rdparty/libprocess/src/tests/decoder_tests.cpp > 5f84d84dc8ff5e1f2684da14d30c1866ad8562d5 > 3rdparty/libprocess/src/tests/http_tests.cpp > d41929a9c8b2469c10b9e31985c447076c1684dc > 3rdparty/libprocess/src/tests/process_tests.cpp > ea798d00a0d0bf6b6623c39904ab3c1c7fd2e555 > 3rdparty/libprocess/src/tests/ssl_client.cpp > 8d62fc2975b585013a8d9a6efc967314d6d8ec47 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 55c8c309571b1892b0acc4d766eda9bb98085a6f > 3rdparty/libprocess/src/tests/test_linkee.cpp > 1f6cfafcb73fd41ef350b13e3ac6023d78f16f5a > > Diff: https://reviews.apache.org/r/53459/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
