----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53760/#review157107 -----------------------------------------------------------
Fix it, then Ship it! src/slave/container_loggers/CMakeLists.txt (line 33) <https://reviews.apache.org/r/53760/#comment227525> Minor nit: probably want to move this directory to a variable? - Alex Clemmer On Nov. 15, 2016, 11:09 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53760/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 11:09 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > This moves some test libraries from the default CMake build > output locations to `<build_dir>/src/.libs`, which is where > the Automake build outputs libraries. We have a few tests > that expect modules to be located in this directory. > > Additionally, this makes the test target (make check) depend > on the test modules and example frameworks, so that they are built > in the correct order. > > > Diffs > ----- > > src/examples/CMakeLists.txt PRE-CREATION > src/slave/container_loggers/CMakeLists.txt PRE-CREATION > src/slave/qos_controllers/CMakeLists.txt > 87c92af21c012655c201c01cd4ba5ff912555119 > src/slave/resource_estimators/CMakeLists.txt > 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 > src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 > > Diff: https://reviews.apache.org/r/53760/diff/ > > > Testing > ------- > > cmake .. > make clean > make > > > Thanks, > > Joseph Wu > >
