----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53764/#review157115 -----------------------------------------------------------
Ship it! src/launcher/CMakeLists.txt <https://reviews.apache.org/r/53764/#comment227533> Are we deleting this line because this is included also in the `src/` directory? Do you think there is any benefit in having submodules include everything they need to build, themselves, rather than depending on the `src/` directory to set it up? - Alex Clemmer On Nov. 15, 2016, 3:15 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53764/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 3:15 a.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > This executor has support for TaskGroups and will eventually take > precedence over the default command executor. > > > Diffs > ----- > > cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 > src/launcher/CMakeLists.txt 3137ea1479970c7ea46e6595536d481002fc585c > > Diff: https://reviews.apache.org/r/53764/diff/ > > > Testing > ------- > > cmake .. > make > > > Thanks, > > Joseph Wu > >
