> On Nov. 28, 2016, 11:01 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 79 > > <https://reviews.apache.org/r/53758/diff/2/?file=1568684#file1568684line79> > > > > Just so I'm clear about this: in other places, we're disabling source > > builds on WIN32 by `if`'ing out the source inclusion in the file, but here > > (because of legacy reasons) we're depending on the "old way" of doing > > stuff, which is to `if` out the `add_subdirectory(tests/)`? > > > > If so, it would be nice to have a transition plan going in -- either > > one of us should clean it up (either in this chain or after it), or we > > should file an issue, I think. Less desirable would be to have two > > different conventions. _i.e._ I personally don't consider the changes > > required to be a stop-ship, but I do consider having a plan to be a stop > > ship. :)
As it stands, so few of the Mesos tests actually build on Windows, so it's not too useful to remove the `if (WIN32)`. The plan should be: 1) We get the CMake build, with tests, working on OSX and Linux (this chain). 2) We get the tests working on Windows, with a separate chain (presumably starting https://reviews.apache.org/r/53550/ ). We will most likely add some more `if (WIN32)` blocks into the test/CMakeLists.txt file during this process. 3) We'll have a single review that removes the `if (WIN32)` around `add_subdirectory(tests/)` once (2) is complete. In the meantime, it's trivial for us contributors to carry around this commit. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53758/#review157106 ----------------------------------------------------------- On Nov. 22, 2016, noon, Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53758/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, noon) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > This adds most existing tests to the CMake build. This excludes > a few special cases, just as Java, Python, and network isolator > tests. > > This review replaces: https://reviews.apache.org/r/49921/ > > > Diffs > ----- > > CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > src/tests/CMakeLists.txt 90b92251b7e133124f6d9a896190ceea402cbff1 > src/tests/cmake/MesosTestsConfigure.cmake > 3f543c010ae87ff04e6b45745bc49ef65b6590ff > > Diff: https://reviews.apache.org/r/53758/diff/ > > > Testing > ------- > > cmake .. > make > > > Thanks, > > Joseph Wu > >
