> On Nov. 28, 2016, 9:28 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 394 > > <https://reviews.apache.org/r/53994/diff/4/?file=1571315#file1571315line394> > > > > Do you need to implicitly capture everything or can we be explicit here?
originally i was capturing explicitly, but when i looked around it seems like we use "=" when the capture includes "this". - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/#review157134 ----------------------------------------------------------- On Nov. 28, 2016, 10:21 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53994/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 10:21 p.m.) > > > Review request for mesos, Anand Mazumdar and Benjamin Mahler. > > > Bugs: MESOS-6473 > https://issues.apache.org/jira/browse/MESOS-6473 > > > Repository: mesos > > > Description > ------- > > Note that this change only updates the handler to correctly > handle non-streaming calls given it receives `PIPE` requests. > Handling streaming calls will come later. > > > Diffs > ----- > > src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f > src/slave/slave.hpp 0cc105418bf4e35b604ebe412048237814e495fb > src/slave/slave.cpp 521f08d59cd78f9089d58cd3294f0ee4a099cd7f > > Diff: https://reviews.apache.org/r/53994/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
