----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54113/#review157188 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/socket.hpp (line 388) <https://reviews.apache.org/r/54113/#comment227623> Can you leave a TODO to avoid having READ as the default in favor of READ_WRITE? Alternatively, we could remove the default entirely. 3rdparty/libprocess/include/process/socket.hpp (line 390) <https://reviews.apache.org/r/54113/#comment227625> Do you want a reference capture? 3rdparty/libprocess/include/process/socket.hpp (lines 392 - 394) <https://reviews.apache.org/r/54113/#comment227624> Be sure to commit greg's windows fix for mapping SHUT_WR and SHUT_RDWR before you commit this. - Benjamin Mahler On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54113/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 6:19 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added support for specifying how a socket should be shutdown. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > f798af7879546d71e8ef4a295c9cf489a70cb61f > > Diff: https://reviews.apache.org/r/54113/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
