> On Nov. 28, 2016, 10:08 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 433 > > <https://reviews.apache.org/r/53460/diff/5/?file=1570940#file1570940line433> > > > > inline is not necessary for template specification? Let's be consistent > > here (either use inline for all of them, or none of them).
`inline` is necessary for a completely specialized template definition, but not for the deleted function so I'll remove it there but keep it the other places. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/#review157097 ----------------------------------------------------------- On Nov. 28, 2016, 6:15 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53460/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 6:15 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Also added unix::Address. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 71319891a451bd1d565210dcce2fb61fc69e1f61 > 3rdparty/libprocess/include/process/address.hpp > 04e3155d65f476208fa852e83b79d173b66288fd > 3rdparty/libprocess/include/process/network.hpp > 52110667185370a4c92e2fa524819ab1f34bdec9 > 3rdparty/libprocess/include/process/socket.hpp > f798af7879546d71e8ef4a295c9cf489a70cb61f > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 21a0fc45b55a368a21b3e616c751ab43eebd4902 > 3rdparty/libprocess/src/address.cpp PRE-CREATION > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 5c0929d3d9f5595bd2f343b98b899fd6b06a67b2 > 3rdparty/libprocess/src/poll_socket.cpp > eb7b48713edd30b545d7be95b5d51b0f71bd422a > 3rdparty/libprocess/src/process.cpp > e9a4bbb0b2410e0260d120b97e73972c94eb0f26 > 3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 > 3rdparty/libprocess/src/tests/socket_tests.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 55c8c309571b1892b0acc4d766eda9bb98085a6f > 3rdparty/libprocess/src/tests/test_linkee.cpp > 1f6cfafcb73fd41ef350b13e3ac6023d78f16f5a > > Diff: https://reviews.apache.org/r/53460/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
