----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/#review157391 -----------------------------------------------------------
Patch looks great! Reviews applied: [54193, 54194, 54196] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 30, 2016, 4 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54196/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 4 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-6471 > https://issues.apache.org/jira/browse/MESOS-6471 > > > Repository: mesos > > > Description > ------- > > In addition to launching the nested container the API handler > ensures that the container is destroyed if the connection breaks. > > > Diffs > ----- > > src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2 > src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa > src/slave/validation.cpp 46e84361244394196ee5d431c1da34686d6c938a > src/tests/api_tests.cpp b2a70f3174824d3cb241a098d96e4d63a390f8bc > > Diff: https://reviews.apache.org/r/54196/diff/ > > > Testing > ------- > > make check > > Added a basic test for now that tests the failure case. Will be adding more > tests in subsequent reviews. > > > Thanks, > > Vinod Kone > >
