----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157476 -----------------------------------------------------------
src/common/http.hpp (lines 66 - 75) <https://reviews.apache.org/r/54218/#comment228078> please make this consistent with `serialize()` src/common/http.cpp (line 105) <https://reviews.apache.org/r/54218/#comment228074> s/protobufSerializeFn/protobufSerializer/ src/common/http.cpp (line 109) <https://reviews.apache.org/r/54218/#comment228076> s/jsonSerializeFn/jsonSerializer/ - Vinod Kone On Nov. 30, 2016, 7:18 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54218/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 7:18 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6472 > https://issues.apache.org/jira/browse/MESOS-6472 > > > Repository: mesos > > > Description > ------- > > The `serialize()` helper can now encode a record in 'Record-IO' > format for streaming content type. Also, `deserialize()` now > handles a streaming content type by just parsing it the body > into a corresponding protobuf. > > > Diffs > ----- > > src/common/http.hpp 378208be58d0cd141ff60a6d25a173f2793870dc > src/common/http.cpp 42af33094150001fa6741effb6b0aee1cde3c109 > > Diff: https://reviews.apache.org/r/54218/diff/ > > > Testing > ------- > > make check (these would be tested later in the chain) > > > Thanks, > > Anand Mazumdar > >
