----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/#review157493 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp (lines 312 - 318) <https://reviews.apache.org/r/53939/#comment228098> probably add a paths function: ``` getContainerIOSwitchboardSocketPath ``` - Jie Yu On Nov. 30, 2016, 6:55 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53939/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 6:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6467 > https://issues.apache.org/jira/browse/MESOS-6467 > > > Repository: mesos > > > Description > ------- > > Added implementation for containerizer 'attach()' call. > > > Diffs > ----- > > src/slave/containerizer/composing.cpp > e0818bce8a8c3561f2fdd1127cea9ce310ae7f4d > src/slave/containerizer/mesos/containerizer.cpp > 4a03f97d10a1b34a0a13600af5ac6fc3679694fd > src/slave/containerizer/mesos/io/switchboard.hpp > aaa3a35245b291f6003f519dbf8c0e1b82bc15fd > src/slave/containerizer/mesos/io/switchboard.cpp > 25cbf2447d197134f0753b062b6f4130821005b2 > > Diff: https://reviews.apache.org/r/53939/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
