-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53853/#review157604
-----------------------------------------------------------




include/mesos/mesos.proto (line 2131)
<https://reviews.apache.org/r/53853/#comment228215>

    s/are set/is set/g



include/mesos/mesos.proto (line 2132)
<https://reviews.apache.org/r/53853/#comment228220>

    `non-container task` may be confusing.
    
    This is a normal task case, but it is still in a container since some 
isolations are still needed. If there is no container image specified for a 
mesos container, it shares the host's rootfs and do not chroot, which should 
not precisely mean the task is not inside a container.


- Gilbert Song


On Nov. 17, 2016, 8:58 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53853/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gilbert Song, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 380575904a5a29ee53bdc87ae8791ed14e3cafca 
>   include/mesos/v1/mesos.proto 5b542ff9cd0b5f301c088d3f4b2fe17ae760d368 
> 
> Diff: https://reviews.apache.org/r/53853/diff/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to