> On Dec. 1, 2016, 9:29 p.m., Greg Mann wrote:
> > src/examples/persistent_volume_framework.cpp, lines 502-508
> > <https://reviews.apache.org/r/45962/diff/23/?file=1571558#file1571558line502>
> >
> >     I would suggest that we should run this test framework in the test 
> > suite with both regular and shared persistent volumes. We could:
> >     1) Do a single run of the test framework which uses both shared and 
> > regular volumes
> >     2) Do a couple different runs of the test framework which each use 
> > different types of volumes.
> >     
> >     This could be accomplished either here in the default flag values, or 
> > by altering the test run script to pass flags in.
> >     
> >     Thoughts?

Sorry! As you pointed out offline, you're already doing this :) Dropping the 
issue.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review157642
-----------------------------------------------------------


On Nov. 29, 2016, 12:25 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated a persistent volume test framework to include shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/examples/persistent_volume_framework.cpp 
> 9d45bb496c4cf378af429b5aa970bf81450e482a 
> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Reply via email to