-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54197/#review157669
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, just a small suggestion about adding a warning for users that we're 
still implementing this and that non MULTI_ROLE frameworks can still assume 
they are being offered resources allocated to their single role.


include/mesos/mesos.proto (lines 786 - 796)
<https://reviews.apache.org/r/54197/#comment228302>

    How about adding a warning to these (v1 and unversioned):
    
    ```
    // This was initially introduced to support MULTI_ROLE capable
    // frameworks. Frameworks that are not MULTI_ROLE capable can
    // continue to assume that the offered resources are allocated
    // to their role.
    //
    // NOTE: Implementation of this is in-progress, DO NOT USE!
    message AllocationInfo {
    ```


- Benjamin Mahler


On Dec. 1, 2016, 2:47 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54197/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Qiang Zhang.
> 
> 
> Bugs: MESOS-6633
>     https://issues.apache.org/jira/browse/MESOS-6633
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To determine which role resources are allocated to, we now need to
> store allocation information within the Resources. This is part of
> the effort to support multi-role frameworks. See MESOS-6633 for more
> details.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto cbfcd8a666e0b4a486f6dcd9e8356c9d5a1cea05 
>   include/mesos/v1/mesos.proto e4f269b96ffc06d040604d1d6fead01e4aca2c13 
> 
> Diff: https://reviews.apache.org/r/54197/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Reply via email to