> On Nov. 21, 2016, 6:47 p.m., Benjamin Mahler wrote: > > Thanks for fixing this! It would be great to include some of the context > > from the ticket so that the commit message provides enough context (and/or > > points to the JIRA). In particular, that before this change, the launching > > of other tasks could be delayed during expensive rmdir operations since > > they all have to be serialized through the garbage collector. Will take a > > closer look after Yan's review.
Ah ok added more context to the commit message. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review156481 ----------------------------------------------------------- On Nov. 12, 2016, 12:48 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53479/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2016, 12:48 a.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6549 > https://issues.apache.org/jira/browse/MESOS-6549 > > > Repository: mesos > > > Description > ------- > > Perform GC asynchronously. > > > Diffs > ----- > > src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e > src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 > > Diff: https://reviews.apache.org/r/53479/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Jacob Janco > >
