-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54274/#review157704
-----------------------------------------------------------


Ship it!




The failed test is expected since the IOSwitchbaord assumes *non* streaming 
requests at the moment. Maybe disable this test and commit this, and I'll 
reenable it in a  follow on patch. Otherwise, I can give you the code that 
fixes this and you can just apply it to this patch. What do you think is best?

- Kevin Klues


On Dec. 2, 2016, 12:11 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54274/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 12:11 a.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This also means that any call sites using this would need to
> read the request body via the `reader` and `request.body` would
> be empty.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> f0f849c524f8abc2f4953857d46bd3f8339b6f5e 
>   3rdparty/libprocess/src/http.cpp 5203fb308e4ba2cd7d00b1c5a96d783c966ef47b 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 4a0d852e304ff50afca090571f82d0848adf1d25 
> 
> Diff: https://reviews.apache.org/r/54274/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to