----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54300/#review157742 -----------------------------------------------------------
Can you please update the `Testing Done` section by adding some context for how to test your case? Such as ``` make make check ``` ``` ./bin/mesos-tests.sh --gtest_filter="FrameworkInfoValidationTest.ValidateRoles" ...output... ``` - Guangya Liu On 十二月 2, 2016, 8:51 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54300/ > ----------------------------------------------------------- > > (Updated 十二月 2, 2016, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Guangya Liu. > > > Bugs: MESOS-6629 > https://issues.apache.org/jira/browse/MESOS-6629 > > > Repository: mesos > > > Description > ------- > > There are three attributes: 'role', 'roles' and MULTI_ROLE to be > validated by this method, therefore covered by 2^3 test cases. > Also the test ensures this method checks duplicate entries in 'roles'. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > 5c44967a077551944831383a6bcc6dcb1c626df9 > > Diff: https://reviews.apache.org/r/54300/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
