----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54301/#review157750 -----------------------------------------------------------
Ship it! It is better always adding something in `Testing Done` section and for this one, you can probaly add following to make sure that your code build and test passed. ``` make make check ``` - Guangya Liu On 十二月 2, 2016, 8:51 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54301/ > ----------------------------------------------------------- > > (Updated 十二月 2, 2016, 8:51 a.m.) > > > Review request for mesos, Benjamin Mahler and Guangya Liu. > > > Bugs: MESOS-6629 > https://issues.apache.org/jira/browse/MESOS-6629 > > > Repository: mesos > > > Description > ------- > > Leveraged validateRoles method introduced in previous patch to > validate FrameworkInfo when a framework subscribes to master. > > > Diffs > ----- > > src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a > > Diff: https://reviews.apache.org/r/54301/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
