----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review157814 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/loop.hpp (lines 32 - 36) <https://reviews.apache.org/r/54295/#comment228413> Can you update this paragraph accordingly? 3rdparty/libprocess/include/process/loop.hpp (lines 91 - 94) <https://reviews.apache.org/r/54295/#comment228414> This needs an update? 3rdparty/libprocess/include/process/loop.hpp (lines 169 - 178) <https://reviews.apache.org/r/54295/#comment228412> Do you want to capture a lambda here like you did for `discard` and `continuation`? - Benjamin Mahler On Dec. 2, 2016, 6:45 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54295/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 6:45 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Added a synchronous version of loop for io::read/write/redirect. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/loop.hpp > a78ea7da8a5a778d816a64fb46d9479cc2a4ed70 > 3rdparty/libprocess/src/io.cpp e81f279ed4bf92f75ad2427550ca822a9b03cca5 > > Diff: https://reviews.apache.org/r/54295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
