----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54297/#review157914 -----------------------------------------------------------
Just a few more minor things to clean up. src/slave/containerizer/mesos/io/switchboard.cpp (lines 832 - 833) <https://reviews.apache.org/r/54297/#comment228558> hmm, the `PROCESS_IO` validation can be done by the agent itself i.e., it seems to be independent of the business logic of the handler. Can you add a `TODO` in the function declaration to move this logic to the agent in `src/slave/validation.hpp` if you don't want to do this now? Also, can you change the method signature to be: ```cpp Option<Error> IOSwitchboardServerProcess::validate( const agent::Call::AttachContainerInput& call) ``` src/slave/containerizer/mesos/io/switchboard.cpp (lines 835 - 840) <https://reviews.apache.org/r/54297/#comment228557> With the change in method signature, move these to the handler (call site) itself. (L964) src/slave/containerizer/mesos/io/switchboard.cpp (lines 863 - 925) <https://reviews.apache.org/r/54297/#comment228560> There seem perfect to use the switch statement on `type()` instead of the `if else` statements? src/slave/containerizer/mesos/io/switchboard.cpp (line 974) <https://reviews.apache.org/r/54297/#comment228561> Any reasons for not using switch statements here? If not, can you use them here? src/slave/containerizer/mesos/io/switchboard.cpp (lines 1012 - 1014) <https://reviews.apache.org/r/54297/#comment228563> Nit: Should fit in one line, no? src/tests/containerizer/io_switchboard_tests.cpp (line 301) <https://reviews.apache.org/r/54297/#comment228562> Nice Test! src/tests/containerizer/io_switchboard_tests.cpp (line 303) <https://reviews.apache.org/r/54297/#comment228556> s/only// - Anand Mazumdar On Dec. 4, 2016, 12:54 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54297/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2016, 12:54 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-6467 > https://issues.apache.org/jira/browse/MESOS-6467 > > > Repository: mesos > > > Description > ------- > > Added support for ATTACH_CONTAINER_INPUT to the io switchboard. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 778367a268ec350ed438bc9fe9d359d63bdb5503 > src/tests/containerizer/io_switchboard_tests.cpp > d82f22b5c9a8d177577db3aeaae9e571e7e2fb80 > > Diff: https://reviews.apache.org/r/54297/diff/ > > > Testing > ------- > > make -j check > > > Thanks, > > Kevin Klues > >
