----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54336/#review158228 -----------------------------------------------------------
Fix it, then Ship it! src/slave/flags.cpp (lines 214 - 222) <https://reviews.apache.org/r/54336/#comment229032> Since we want to (eventually) add something like an `os::var()`, you should add a TODO here to note that. - Joseph Wu On Dec. 5, 2016, 5:06 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54336/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 5:06 p.m.) > > > Review request for mesos and Alex Clemmer. > > > Bugs: MESOS-6677 > https://issues.apache.org/jira/browse/MESOS-6677 > > > Repository: mesos > > > Description > ------- > > This commit fixes MESOS-6677, which breaks the ability > to run any agent on Windows, and thus is blocking all > Windows development progress on the `master` branch. > > The cause was that the default `runtime_dir` value was POSIX specific, > and used `os::user()` which is deleted on Windows. > The fix is to guard the POSIX code, and add a > Windows implementation. > > > Diffs > ----- > > src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 > src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 > > Diff: https://reviews.apache.org/r/54336/diff/ > > > Testing > ------- > > make && make check on Linux: 1411 tests passed, no failures. > > msbuild and attached to Linux master: no runtime failures. > > > Thanks, > > Andrew Schwartzmeyer > >
