----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54472/#review158304 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp (lines 635 - 636) <https://reviews.apache.org/r/54472/#comment229087> @bmahler alwasy wanted me to put the " " on the next line instead of ending a line with a space. We seem to be inconsistent about this overall so I've adopted his way so that I mayself am consistent. - Kevin Klues On Dec. 7, 2016, 5:21 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54472/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 5:21 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: MESOS-6737 > https://issues.apache.org/jira/browse/MESOS-6737 > > > Repository: mesos > > > Description > ------- > > Do not try to connect to the domain socket until the socket file has > been created by the server. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > c54d64efe7dc526473427bca89a1b65205e16018 > src/tests/containerizer/io_switchboard_tests.cpp > 851a1015294882ca5401cb8fd60ceff6f933249d > > Diff: https://reviews.apache.org/r/54472/diff/ > > > Testing > ------- > > bin/mesos-tests.sh --gtest_filter=IOSwitchboardTest.ContainerAttach > --gtest_repeat=100 > > > Thanks, > > Jie Yu > >
