----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54200/#review158386 -----------------------------------------------------------
Fix it, then Ship it! Can you follow up with a unit test for this function? src/common/protobuf_utils.hpp (lines 204 - 209) <https://reviews.apache.org/r/54200/#comment229145> Looks like you need a set include now? - Benjamin Mahler On Dec. 7, 2016, 8:59 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54200/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 8:59 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-6635 > https://issues.apache.org/jira/browse/MESOS-6635 > > > Repository: mesos > > > Description > ------- > > The function returns a set<string> containing all roles in a > multi-role FrameworkInfo. For single-role FrameworkInfo, there > is only one element in the set. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4 > src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0 > > Diff: https://reviews.apache.org/r/54200/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
