----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54487/#review158394 -----------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.cpp (lines 547 - 548) <https://reviews.apache.org/r/54487/#comment229154> One more thing (already after the fact). This enumeration misses env vars with the `SSL_` prefix which we also potentially interpret (in SSL-enabled builds), see https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob;f=3rdparty/libprocess/src/openssl.cpp;h=e6f17e4591f573186e1dc9697e1e7b60a841fe4f;hb=HEAD#l307. As is, this code likely breaks many just slightly customized SSL setups. Since we plan to phase out support for `SSL_`-prefixed vars at some point in the future, do you think it would make sense to capture this logic in a helper? That would lessen the potential for regressions when somebody implements the next external process. - Benjamin Bannier On Dec. 7, 2016, 8:28 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54487/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 8:28 p.m.) > > > Review request for mesos, Joseph Wu, Kevin Klues, and Till Toenshoff. > > > Bugs: MESOS-6748 > https://issues.apache.org/jira/browse/MESOS-6748 > > > Repository: mesos > > > Description > ------- > > THe I/O switchboard server process will inheirt most of the agent > environment variables, except for those that are prefixed with MESOS > or LIBPROCESS since we don't rely on those environment variables. > > The patch also manually set a few LIBPROCESS environment variables to > make sure the libprocess for the I/O switchboard can be initailzied > properly without depending on external environment. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 4452d5ad26881487825e58a3a052e6d07bac2321 > > Diff: https://reviews.apache.org/r/54487/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
