> On Dec. 7, 2016, 10:05 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 3990 > > <https://reviews.apache.org/r/54497/diff/1/?file=1579073#file1579073line3990> > > > > why is this an Option?
The class does not have a default constructor. So, I cannot "instantiate" an object for it. > On Dec. 7, 2016, 10:05 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, lines 4094-4118 > > <https://reviews.apache.org/r/54497/diff/1/?file=1579073#file1579073line4094> > > > > can't we use http::post() here? would be nice to add support to send > > streaming request to that function. Yeah, we need to add an overload to `post()` to support streaming requests. I filed: https://issues.apache.org/jira/browse/MESOS-6752 - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54497/#review158388 ----------------------------------------------------------- On Dec. 8, 2016, 12:39 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54497/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 12:39 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Review: https://reviews.apache.org/r/54497 > > > Diffs > ----- > > src/tests/api_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966 > > Diff: https://reviews.apache.org/r/54497/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
