----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54470/#review158434 -----------------------------------------------------------
Ship it! LGTM. src/slave/http.cpp (lines 952 - 956) <https://reviews.apache.org/r/54470/#comment229209> This is just an example JSON blob. I don't think ifdef-ing this is worthwhile :) I can remove it before committing if you agree. - Joseph Wu On Dec. 6, 2016, 9:09 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54470/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 9:09 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-6717 > https://issues.apache.org/jira/browse/MESOS-6717 > > > Repository: mesos > > > Description > ------- > > Windows: Fixed default isolators in Agent. > > This commit partially addresses MESOS-6717, specifically the fact that > some of the default isolators currently used by the Agent are > POSIX-specific, and will cause every Agent test to crash. > > In particular, this commit will transition Windows builds of the agent > away from using the `posix/cpu`, `posix/mem`, and `filesystem/posix` > isolators by default, replacing them with `windows/cpu` and > `filesystem/windows` (sadly, there is not yet a memory isolator for > Windows). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 6d50755fa24eb67bb72a78f9acc69c7e5eecabe2 > src/slave/flags.cpp 67326eece05e6300d1407ed8887aabb2f06fe9cd > src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef > src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd > > Diff: https://reviews.apache.org/r/54470/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
