> On Dec. 8, 2016, 1:17 a.m., Joseph Wu wrote: > > src/tests/mesos.cpp, lines 146-147 > > <https://reviews.apache.org/r/54453/diff/1/?file=1578153#file1578153line146> > > > > I'm going to add a TODO here (to consider changing this back to > > `replicated_log`). > > > > At some point in future, we'll support the replog on Windows (in some > > form). When that happens, I think we can consider flipping this back to > > increase code coverage.
Alright, that sounds great. Thanks Joseph! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54453/#review158448 ----------------------------------------------------------- On Dec. 6, 2016, 10:34 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54453/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 10:34 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-6695 and MESOS-6697 > https://issues.apache.org/jira/browse/MESOS-6695 > https://issues.apache.org/jira/browse/MESOS-6697 > > > Repository: mesos > > > Description > ------- > > Currently, nearly all instances of the Master in our tests have the > `replicated_log` flag turned on. On Windows, this will cause all tests > that involve instantiating a Master to fail immediately. > > This commit will solve this problem by setting the default master flags > to set `in_memory` instead, and then selectively turning on > `replicated_log` when it's necessary. > > NOTE: This commit is largely a resurrection of #41665. And, although it > is meant specifically to address MESOS-6697, this issue actually affects > almost all open issues in MESOS-6695. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > 6f1e249e51e41aee7fdb22a2ccbfa9be71774e6d > src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 > src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd > src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 > src/tests/reconciliation_tests.cpp 71073a05a702dffd4c8e10c3c125a144ac8ca41d > > Diff: https://reviews.apache.org/r/54453/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
