> On Dec. 8, 2016, 2:15 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 815 > > <https://reviews.apache.org/r/54518/diff/1/?file=1579626#file1579626line815> > > > > Why do you have to do things this way? With the `await()` and the > > `list` of futures. > > > > Can't we just have an `.onAny()` on status?
Unfortunately, 'status' is a `Future<Option<int>>` and the return value of this method is `Future<Nothing>`. I cannot use `.then` to chain becaues I care about the failure/discarded case as well. > On Dec. 8, 2016, 2:15 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 849-853 > > <https://reviews.apache.org/r/54518/diff/1/?file=1579626#file1579626line849> > > > > When does this case happen? is waitpid returns a failure, we might get this, which i believe should not happen. Just a bit of defensive. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54518/#review158479 ----------------------------------------------------------- On Dec. 8, 2016, 1:46 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54518/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 1:46 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-6756 > https://issues.apache.org/jira/browse/MESOS-6756 > > > Repository: mesos > > > Description > ------- > > Previously, we don't handle the case where reaping failed. This patch > refactored the reaping logic. The main idea is to register a 'reaped' > callback which gets invoked when the reaping of the I/O switchboard > server process has a result. This also changes the 'watch' logic. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.hpp > a8a1e2558432ae1e4c7e5513e5653feba4352056 > src/slave/containerizer/mesos/io/switchboard.cpp > af956951de9c605c68f6ec16a7edf3c33f4bd499 > > Diff: https://reviews.apache.org/r/54518/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
