----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54483/#review158514 -----------------------------------------------------------
Ship it! Thanks Neil! - Jiang Yan Xu On Dec. 7, 2016, 7:55 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54483/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 7:55 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Fixed GMock warning. > > > Diffs > ----- > > src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 > > Diff: https://reviews.apache.org/r/54483/diff/ > > > Testing > ------- > > `make check` > > Without this change, the following GMock warning occurs on a slow VM: > > ``` > [ RUN ] MasterTest.UnregisteredFrameworksAfterTearDown > > GMOCK WARNING: > Uninteresting mock function call - returning directly. > Function call: resourceOffers(0x7ffeb925c890, @0x7f44456699d0 { 152-byte > object <18-E9 39-53 44-7F 00-00 00-00 00-00 00-00 00-00 1F-00 00-00 00-00 > 00-00 70-D7 00-24 44-7F 00-00 E0-4D 00-24 44-7F 00-00 40-BA 00-24 44-7F 00-00 > 10-E0 00-24 44-7F 00-00 70-A5 00-24 44-7F 00-00 ... 00-00 00-00 00-00 00-00 > 00-00 00-00 00-00 00-00 00-00 00-00 44-7F 00-00 00-00 00-00 00-00 00-00 00-00 > 00-00 00-00 00-00 00-00 00-00 44-7F 00-00 00-00 00-00 00-00 00-00 00-00 00-00 > 00-00 00-00> }) > Stack trace: > [ OK ] MasterTest.UnregisteredFrameworksAfterTearDown (813 ms) > [----------] 1 test from MasterTest (814 ms total) > ``` > > With this change, no GMock warnings are observed in ~500 test runs. > > > Thanks, > > Neil Conway > >
