----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54522/#review158552 -----------------------------------------------------------
Fix it, then Ship it! src/tests/protobuf_utils_tests.cpp (line 33) <https://reviews.apache.org/r/54522/#comment229329> No need for this to be a mesos test (at which point you won't need the include). src/tests/protobuf_utils_tests.cpp (lines 43 - 62) <https://reviews.apache.org/r/54522/#comment229330> How about "role1", "role2" and "role" to make this more straightforward? - Benjamin Mahler On Dec. 8, 2016, 6:07 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54522/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 6:07 a.m.) > > > Review request for mesos, Benjamin Mahler and Guangya Liu. > > > Bugs: MESOS-6635 > https://issues.apache.org/jira/browse/MESOS-6635 > > > Repository: mesos > > > Description > ------- > > Added a test for `getRoles` helper function. > > > Diffs > ----- > > src/Makefile.am 011ed6cdfd96956ff6634464bb78005f3925c1b6 > src/tests/protobuf_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54522/diff/ > > > Testing > ------- > > make check GTEST_FILTER="ProtobufUtilTest.GetRoles" > > > Thanks, > > Jay Guo > >
