----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54281/#review158473 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp (line 3753) <https://reviews.apache.org/r/54281/#comment229239> s/stederr/stderr src/tests/api_tests.cpp (line 3787) <https://reviews.apache.org/r/54281/#comment229241> Kill this? src/tests/api_tests.cpp (line 3797) <https://reviews.apache.org/r/54281/#comment229331> Kill this? src/tests/api_tests.cpp (lines 3806 - 3807) <https://reviews.apache.org/r/54281/#comment229338> How about: ```cpp // Launch a nested container session that runs a command that writes something to stdout and stderr and exits. ``` src/tests/api_tests.cpp (line 3811) <https://reviews.apache.org/r/54281/#comment229340> hmm, we should change it to `ASSERT_EQ` since the next step would likely crash if the size is 0. There are other tests that do so, would be worth doing a sweep later. src/tests/api_tests.cpp (lines 3817 - 3818) <https://reviews.apache.org/r/54281/#comment229337> Might want to make the string themselves be "stdout"/"stderr"? - Anand Mazumdar On Dec. 8, 2016, 1:23 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54281/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 1:23 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This test verifies that launch results in output being streamed. > > > Diffs > ----- > > src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61 > > Diff: https://reviews.apache.org/r/54281/diff/ > > > Testing > ------- > > make -j20 check GTEST_FILTER="*LaunchNestedContainerSession*" GLOG_v=1 > MESOS_VERBOSE=1 > > > Thanks, > > Vinod Kone > >
